Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode wether or not a chunk is sorted by RowId in the column metadata #9041

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 14, 2025

It used to be encoded in the RecordBatch metadata. It makes more sense to encode it on the column metadata though, and brings the RowId column closer to the time columns (I hope to unify the two in the near future).

* Part of #8744

It used to be encoded in the `RecrodBatch` metadata.
It makes more sense to encode it on the column metadata though,
and brings the RowId column closer to the time columns
(I hope to unify the two in the near future).
@emilk emilk added exclude from changelog PRs with this won't show up in CHANGELOG.md 🔩 data model Sorbet labels Feb 14, 2025
@emilk emilk force-pushed the emilk/encode-row-id-sort-in-column-metadata branch from fb6eaf3 to 535d8c2 Compare February 14, 2025 11:19
Copy link

github-actions bot commented Feb 14, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
db865fc https://rerun.io/viewer/pr/9041 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc self-requested a review February 17, 2025 08:12
@emilk emilk merged commit 20b8122 into main Feb 17, 2025
35 checks passed
@emilk emilk deleted the emilk/encode-row-id-sort-in-column-metadata branch February 17, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model Sorbet exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants